Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests to check metrics labels #96045

Merged
merged 3 commits into from Nov 11, 2020
Merged

tests to check metrics labels #96045

merged 3 commits into from Nov 11, 2020

Conversation

leilajal
Copy link
Contributor

@leilajal leilajal commented Oct 30, 2020 •
edited

What type of PR is this?
/ kind bug

What this PR does / why we need it:
Adding more comprehensive test for mapping url paths to metrics labels
Which issue(s) this PR fixes:

Fixes #95636

fix labels in reporting for kube-apiserver metrics

Special notes for your reviewer:
Tests get a baseline of the current metrics, then using test tables to perform various pod and namespace operations. After the operation completes, we get the new generated metric, and compare it to a string representation of the desired metric in the test case.

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 30, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @leilajal!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @leilajal. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Oct 30, 2020
@k8s-ci-robot k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. release-note-none Denotes a PR that doesn't merit a release note. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 30, 2020
@leilajal
Copy link
Contributor Author

cc @logicalhan

@logicalhan
Copy link
Member

/assign

@leilajal
Copy link
Contributor Author

/assign @logicalhan

@neolit123
Copy link
Member

/uncc

@k8s-ci-robot k8s-ci-robot removed the request for review from neolit123 October 30, 2020 23:32
qiutongs
qiutongs reviewed Nov 3, 2020
View reviewed changes
test/integration/metrics/metrics_test.go Outdated Show resolved Hide resolved
test/integration/metrics/metrics_test.go Outdated Show resolved Hide resolved
test/integration/metrics/metrics_test.go Outdated Show resolved Hide resolved
@dims
Copy link
Member

dims commented Nov 3, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 3, 2020
oomichi
oomichi reviewed Nov 3, 2020
View reviewed changes
Copy link
Member

@oomichi oomichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The additional tests seem good for me.
Just comments about error messages, that seems copy&paste mistakes.

/cc @oomichi

test/integration/metrics/metrics_test.go Outdated Show resolved Hide resolved
test/integration/metrics/metrics_test.go Outdated Show resolved Hide resolved
@spiffxp spiffxp added do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Nov 5, 2020
@leilajal leilajal requested a review from oomichi November 5, 2020 19:47
@oomichi
Copy link
Member

oomichi commented Nov 6, 2020

Thanks for updating.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 6, 2020
@oomichi
Copy link
Member

oomichi commented Nov 6, 2020

/triage accepted
/kind cleanup

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Nov 6, 2020
@leilajal
Copy link
Contributor Author

@oomichi @dims @qiutongs what do we need for this? Thanks!

@oomichi
Copy link
Member

oomichi commented Nov 10, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leilajal, oomichi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 10, 2020
@k8s-ci-robot k8s-ci-robot merged commit 57908e7 into kubernetes:master Nov 11, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Nov 11, 2020
@leilajal leilajal mentioned this pull request Dec 7, 2020
Closed
6 tasks
@qiutongs qiutongs mentioned this pull request Dec 9, 2020
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiutongs qiutongs qiutongs left review comments

@dims dims Awaiting requested review from dims

@oomichi oomichi Awaiting requested review from oomichi

Assignees

@logicalhan logicalhan

@oomichi oomichi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

More comprehensive test for mapping url paths to metrics labels
8 participants
@leilajal @k8s-ci-robot @logicalhan @neolit123 @dims @oomichi @qiutongs @spiffxp